Skip to content

Don't try to download windows exe/msi and mac universal pkg if it doesn't exists for python version requested #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't try to download windows exe/msi and mac universal pkg if it doesn't exists for python version requested #276

wants to merge 2 commits into from

Conversation

jmarrec
Copy link

@jmarrec jmarrec commented May 29, 2024

Only some minor versions of python have an actual windows .exe / .msi installer.

eg:

@jmarrec jmarrec requested a review from a team as a code owner May 29, 2024 05:30
@jmarrec jmarrec changed the title Don't try to continue for windows if download link for exe/msi doesn't exists for python version requested Don't try to download windows exe/msi and mac universal pkg if it doesn't exists for python version requested May 29, 2024
@mayeut
Copy link
Contributor

mayeut commented Jun 1, 2024 •
edited
Loading

Rather than silently ignore some network failures that would lead to the version being skipped, the json returned by https://www.python.org/api/v2/downloads/release/?is_published=true/https://www.python.org/api/v2/downloads/release_file/?release=... should be parsed to check if the package exists or not. This shall probably be done while generating the build matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmarrec @mayeut